Skip to content

Show maintainer instead of author in lib manager #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Show maintainer instead of author in lib manager #10849

merged 1 commit into from
May 10, 2021

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 12, 2020

@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10849-BUILD-985-linux32.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10849-BUILD-985-linux64.tar.xz
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10849-BUILD-985-windows.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10849-BUILD-985-macosx.zip
⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-10849-BUILD-985-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

matthijskooijman
matthijskooijman reviewed Oct 12, 2020
View reviewed changes
app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java
@@ -196,7 +196,7 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
desc += format("{0}", paragraph);
desc += "<br />";
}
if (author != null && !author.isEmpty()) {
if (maintainer != null && !maintainer.isEmpty()) {
desc = setButtonOrLink(moreInfoButton, desc, moreInfoLbl, website);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this change, but why does this if exist? Seems like you don't get a "More info" button/link when no author (or now maintainer) is set, but that doesn't make sense to me?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should be website != null && !website.isEmpty(), I guess we may fix it together with this PR.

@facchinm facchinm added this to the Release 1.8.14 milestone Dec 1, 2020
@cmaglie cmaglie merged commit 7a9db6c into arduino:master May 10, 2021
@cmaglie cmaglie deleted the show-maintainer-in-lib-manager branch May 10, 2021 13:55
@luigigubello
Copy link
Contributor

Great work Tooling team! 💯 🦄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman left review comments

+1 more reviewer

@luigigubello luigigubello luigigubello approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.14
Development

Successfully merging this pull request may close these issues.
5 participants
@cmaglie @ArduinoBot @luigigubello @matthijskooijman @facchinm